Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cni): read CNI YAML outside of the dynamic provider and update to v1.5.3 #223

Merged
merged 2 commits into from
Aug 16, 2019

Conversation

metral
Copy link
Contributor

@metral metral commented Aug 13, 2019

Fixes #219
Related #149

Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
nodejs/eks/cni/aws-k8s-cni.yaml Show resolved Hide resolved
@metral
Copy link
Contributor Author

metral commented Aug 15, 2019

Feedback has been addressed. PTAL @lukehoban

@metral metral merged commit ff2522b into master Aug 16, 2019
@pulumi-bot pulumi-bot deleted the metral/fix-cni-file branch August 16, 2019 03:29
Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-hoc LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants