Add new publicSubnetIds and privateSubnetIds cluster options. Also, update tests to use new awsx.ec2.Vpc API and new subnet options #238
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
feat(subnetIds): add new opts: publicSubnetIds and privateSubnetIds
This change intends to tackle 2 cases:
public and private subnets, and
cluster. This should produce expected results for nodegroup subnet definition
between initial updates and proceeding empty preview steps.
Cluster worker subnet definition benefits from having individual
publicSubnetIds
and
privateSubnetIds
options, as they are:computeWorkerSubnets()
in the NodeGroup class is an approximationof the which subnets belong to which class, and it can occassionaly experience
non-deterministic issues.
fix(tests): update awsx.Network -> awsx.ec2.Vpc & use specific subnetIds
awsx.Network
to the newerawsx.ec2.Vpc
API.awsx.ec2.Vpc
settings already set by defaults.eks.Cluster.subnetIds
tonow use the new subnet options:
eks.Cluster.publicSubnetIds
andeks.Cluster.privateSubnetIds
.test(awsx-network-and-subnetIds): add test of older VPC & network setup
Add new test which creates EKS clusters using the previous
awsx.Network
APIand related cluster network setups.
This test creates two types of clusters that use the previous network API setup:
awsx.Network
API, and clustersubnetIds
.awsx.Network
API, clustersubnetIds
, and a node group with thenodeSubnetIds
override option.Related issues
Closes #199
Closes #179