feat(nodegroup): use the latest recommended AMIs from the SSM store #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metral
force-pushed
the
metral/ssm-ami-ids
branch
3 times, most recently
from
baa5711
to
0c9f9bd
Compare
lukehoban
reviewed
Apr 2, 2020
lblackstone
reviewed
Apr 2, 2020
lukehoban
reviewed
Apr 2, 2020
But we apply |
metral
force-pushed
the
metral/ssm-ami-ids
branch
from
0c9f9bd
to
f18437e
Compare
|
Feedback has been addressed. PTAL @lblackstone @lukehoban |
metral
force-pushed
the
metral/ssm-ami-ids
branch
2 times, most recently
from
e64cfab
to
66fbb20
Compare
metral
force-pushed
the
metral/ssm-ami-ids
branch
4 times, most recently
from
fa954e1
to
5d2da74
Compare
metral
force-pushed
the
metral/ssm-ami-ids
branch
2 times, most recently
from
1855a6f
to
5d98053
Compare
metral
changed the title
metral
force-pushed
the
metral/ssm-ami-ids
branch
2 times, most recently
from
506b3cb
to
3131886
Compare
lblackstone
requested changes
Apr 6, 2020
metral
force-pushed
the
metral/ssm-ami-ids
branch
from
3131886
to
a9652bb
Compare
lblackstone
reviewed
Apr 6, 2020
- Default to the latest recommended AMI IDs from the AWS SSM Parameter Store. - Add new `NodeGroupOption`: `gpu` to use the latest recommended EKS Optimized Linux AMI with GPU support. See for more details: - https://docs.aws.amazon.com/eks/latest/userguide/retrieve-ami-id.html - https://docs.aws.amazon.com/eks/latest/userguide/eks-optimized-ami.html - https://docs.aws.amazon.com/systems-manager/latest/userguide/systems-manager-parameter-store.html
metral
force-pushed
the
metral/ssm-ami-ids
branch
from
a9652bb
to
f32e2cc
Compare
lblackstone
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
feat(nodegroup): use the latest recommended AMIs from the SSM store
NodeGroupOption:gputo use the latest recommended EKSOptimized Linux AMI with GPU support.
See for more details:
Related issues (optional)
Closes #258
Closes #354