Using and testing non-default AWS credentials #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metral
force-pushed
the
metral/aws-providers
branch
10 times, most recently
from
ce22694
to
ebc6a40
Compare
metral
changed the title
metral
force-pushed
the
metral/aws-providers
branch
3 times, most recently
from
4594e65
to
561b115
Compare
metral
changed the title
metral
changed the title
lblackstone
requested changes
Apr 13, 2020
lblackstone
requested changes
Apr 13, 2020
metral
force-pushed
the
metral/aws-providers
branch
3 times, most recently
from
c9db5f3
to
0d00315
Compare
This needs to be updated since the replacement of `aws-iam-authenticator` for `aws eks get-token` in the kubeconfig exec-based auth changed the number of args.
This change moves away from setting and using the AWS environment variables in Travis: `AWS_ACCESS_KEY_ID` and `AWS_SECRET_ACCESS_KEY`, to using `aws configure` in the Travis install phase to setup all AWS creds. The existence of the standard AWS environment variables always takes precedence over alternative AWS auth methods, which does not allow the use of AWS named profiles if necessary.
metral
force-pushed
the
metral/aws-providers
branch
2 times, most recently
from
3a5849e
to
2b23606
Compare
metral
force-pushed
the
metral/aws-providers
branch
from
2b23606
to
133a416
Compare
Co-Authored-By: Levi Blackstone <levi@pulumi.com>
Add `providerCredentialOpts` to scope the cluster's kubeconfig to the AWS credentials used in certain auth scenarios. For example: - Creating and using a new AWS provider instance, or - Setting the AWS_PROFILE environment variable, or - Using a named profile configured on the AWS provider via: `pulumi config set aws:profile <profileName>` This fixes the use of profiles to properly create the k8s VPC CNI and aws-auth ConfigMap. See for more details: - https://www.pulumi.com/docs/reference/pkg/nodejs/pulumi/aws/#Provider - https://www.pulumi.com/docs/intro/cloud-providers/aws/setup/ - https://www.pulumi.com/docs/intro/cloud-providers/aws/#configuration - https://docs.aws.amazon.com/eks/latest/userguide/create-kubeconfig.html
metral
force-pushed
the
metral/aws-providers
branch
from
133a416
to
988488c
Compare
|
Feedback has been addressed. PTAL @lblackstone |
lblackstone
reviewed
Apr 17, 2020
metral
force-pushed
the
metral/aws-providers
branch
from
988488c
to
cff44f9
Compare
lblackstone
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The following changes are related to using and testing alternative AWS credentials, instead of the default credential chain, to create EKS clusters.
CI:
Fixes CI smoke test bug
Updates CI AWS auth to use
aws configureto allow the use of alternative named profiles.Note: TravisCI environment variables were also updated to work with
aws configure.Cluster:
Pass an AWS provider to all AWS resources if one is set in the cluster resource options.
Note: Tested in CloudTrail for alternative profile use to
get/createall AWS resources.kubeconfig + non-default AWS creds:
providerCredentialOptsto configure the cluster's kubeconfig auth when using a non-default AWS creds chain (e.g. such as using named profiles or AWS provider instance).Related issues (optional)
Fixes #368
Fixes #369
Closes #370
Fixes #296