Support for the ENI_CONFIG_LABEL_DEF environment variable #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closing this, will reopen after it passes internal review. |
|
The build error in travis ci does not seem related to my change, seems like an env var is not getting set, from what I can tell: |
metral
suggested changes
Jul 30, 2020
No worries, I'll have to shepherd this PR through since the secrets are not available for public use. |
metral
approved these changes
Aug 4, 2020
Merged
|
Merged this PR in via #412 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When an EKS cluster worker node group is spread across multiple availability zones,
and we want to use custom CNI networking, EKS allows you to specify the
ENI_CONFIG_LABEL_DEF environment variable value for worker nodes
This is used to tell Kubernetes to automatically apply the ENIConfig for each Availability Zone
Ref: https://docs.aws.amazon.com/eks/latest/userguide/cni-custom-network.html (step 6(c)).
This PR exposes the env variable in the CNI module in pulumi-eks.
Related issues (optional)
Addresses issue #410