Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nodegroup): add nodeUserDataOverride arg to specify userdata script #429

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

metral
Copy link
Contributor

@metral metral commented Aug 20, 2020

Proposed changes

feat(nodegroup): add nodeUserDataOverride arg to specify userdata script

Related issues (optional)

Closes #428

@metral metral force-pushed the metral/add-userdata-override branch from b3f97c6 to a5c9b79 Compare August 20, 2020 21:11
@metral
Copy link
Contributor Author

metral commented Aug 21, 2020

cc @gunniwho

@gunniwho
Copy link

gunniwho commented Aug 21, 2020

It might be useful to add some validation because there are now args that will be ignored if you specify nodeUserDataOverride - specifically taints, kubeletExtraArgs and bootstrapExtraArgs. Otherwise, looks good to me.

@metral metral force-pushed the metral/add-userdata-override branch from a5c9b79 to 2b3e562 Compare August 28, 2020 18:40
@metral metral merged commit b087075 into master Aug 28, 2020
@pulumi-bot pulumi-bot deleted the metral/add-userdata-override branch August 28, 2020 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support supplying node group user data override for custom scenarios
3 participants