Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade aws-k8s-cni to v1.7.5 #496

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Upgrade aws-k8s-cni to v1.7.5 #496

merged 1 commit into from
Mar 4, 2021

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Dec 22, 2020

Fixes: #453

Proposed changes

Related issues (optional)

@stack72 stack72 requested a review from leezen December 22, 2020 20:18
@stack72 stack72 self-assigned this Dec 22, 2020
@stack72
Copy link
Contributor Author

stack72 commented Dec 22, 2020

@leezen
Copy link
Contributor

leezen commented Dec 22, 2020

I'm not 100% sure how to review this at this point. Is there any divergence between what we want in the manifest vs. what's default to AWS? For a while, there was the divergence with fargate in #291 but that divergence disappeared a year ago in aws/amazon-vpc-cni-k8s#792 -- is there any else materially different that should be preserved?

@emiioan
Copy link

emiioan commented Jan 12, 2021

Any updated on this? We just upgraded our eks clusters to 1.16 and we are using for now a fork and override the yaml file with 1.7.5 version but we will really want to use the upstream library. Also double check yaml compute function because for now if you provide vpcCniOptions: { warmIpTarget: 2}, env var "WARM_IP_TARGET" is not picked up by cni Daemonset.

@emiioan
Copy link

emiioan commented Mar 3, 2021

Hello, when should we expect to have this merged into master branch?

@stack72 stack72 merged commit 5330ad0 into master Mar 4, 2021
@pulumi-bot pulumi-bot deleted the gh-453 branch March 4, 2021 23:48
@justinvp justinvp mentioned this pull request Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update aws-node amazon-k8s-cni to v1.7.5
3 participants