Use the new EKS bootstrap script #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just what it says on the tin.
ericrudder
changed the title
lukehoban
approved these changes
Sep 11, 2018
nodejs/eks/cluster.ts
Outdated
| systemctl daemon-reload | ||
| systemctl restart kubelet kube-proxy | ||
| const clusterCaData = eksCluster.certificateAuthority.apply(ca => Buffer.from(ca.data).toString("base64")); | ||
| const userdata = pulumi.all([awsRegion, eksCluster.name, eksCluster.endpoint, clusterCaData]) |
There was a problem hiding this comment.
Minor - but looks like we no longer need region? (and similarly the line above that gets it?)
|
BTW - Any reason we aren't running integration tests on PRs (or merges to master)? Seems it would be useful to run that extra validation. |
- Add the ability to attach a public key to EC2 worker nodes. - Attach a root volume to worker nodes with a configurable size that defaults to 20GiB. - Incorporate parent names in all child resources. - Add an ingress rule that accommodates extension API servers. - Use CloudFormation to set up the ASG in order to get rolling updates on launch configuration changes. - Fix the type token for `ServiceRole`.
lukehoban
approved these changes
Sep 11, 2018
nodejs/eks/cluster.ts
Outdated
| instanceLaunchConfiguration.id, | ||
| pulumi.output(args.desiredCapacity || 2), | ||
| pulumi.output(args.minSize || 1), | ||
| pulumi.output(args.maxSize || 2), |
There was a problem hiding this comment.
Minor - but pretty sure the pulumi.output is not needed here.
nodejs/eks/transform.ts
Outdated
| } | ||
| } | ||
|
|
||
| export default function transform<T, U>(name: string, input: T, func: (v: T) => U, opts?: pulumi.CustomResourceOptions): pulumi.Output<U> { |
There was a problem hiding this comment.
If we're going to include this (and it seems overkill for the task) - let's add a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just what it says on the tin.