Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the providerCredentialOpts error clearer #559

Merged
merged 4 commits into from
Apr 16, 2021
Merged

make the providerCredentialOpts error clearer #559

merged 4 commits into from
Apr 16, 2021

Conversation

jaxxstorm
Copy link
Contributor

Fixes #558

@jaxxstorm jaxxstorm force-pushed the jaxxstorm/provider-cred-error branch from 2c3b785 to 986fa21 Compare April 15, 2021 00:16
clstokes
clstokes approved these changes Apr 15, 2021
View reviewed changes
Copy link

@clstokes clstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - definite improvement on usability and actionability of these messages for the end user.

lukehoban
lukehoban reviewed Apr 15, 2021
View reviewed changes
nodejs/eks/cluster.ts Outdated Show resolved Hide resolved
jaxxstorm and others added 3 commits April 15, 2021 11:03
@jaxxstorm
remove the link
81ca522 
We can't currently link to language agnostic anchors, so removing the
link for now
@jaxxstorm
update changelog
3f997a9
@stack72
Set dotnet nuget package source once in acceptance tests PR
dbc260c
@jaxxstorm jaxxstorm merged commit 41eb565 into master Apr 16, 2021
@pulumi-bot pulumi-bot deleted the jaxxstorm/provider-cred-error branch April 16, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehoban lukehoban lukehoban left review comments

@stack72 stack72 stack72 approved these changes

@clstokes clstokes clstokes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Profile error wording is confusing
4 participants
@jaxxstorm @lukehoban @stack72 @clstokes