[nodejs] Add resource registration for VpcCni #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
The `VpcCni` resource can be passed back to the TypeScript implementation from other languages as a resource reference, and needs to be instantiated as an instance of `VpcCni` when deserialized so it can be used in a `dependsOn`.
Does the PR have any schema changes?Looking good! No breaking changes found. |
justinvp
commented
May 28, 2021
| @@ -20,7 +20,7 @@ provider:: | |||
|
|
|||
| build_nodejs:: VERSION := $(shell pulumictl get version --language javascript) | |||
| build_nodejs:: | |||
| rm -rf nodejs/eks/bin | |||
| rm -rf nodejs/eks/bin/* | |||
There was a problem hiding this comment.
Otherwise, deleting the whole bin dir was preventing subsequent yarn link calls in the install_nodejs_sdk target from succeeding after a prior yarn link.
Does the PR have any schema changes?Looking good! No breaking changes found. |
lblackstone
reviewed
May 28, 2021
lblackstone
approved these changes
May 28, 2021
We don't and I'm not sure we can yet because I hit another issue after this is fixed. Will open a new issue to track it. |
|
@justinvp Is this still needed? |
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
VpcCniresource can be passed back to the TypeScript implementation from other languages as a resource reference, and needs to be instantiated as an instance ofVpcCniwhen deserialized so it can be used in adependsOn.Part of #566