Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warmPrefixTarget and enablePrefixDelegation support to vpc cni op… #618

Merged
merged 5 commits into from
Nov 11, 2021
Merged

Add warmPrefixTarget and enablePrefixDelegation support to vpc cni op… #618

merged 5 commits into from
Nov 11, 2021

Conversation

davidroth
Copy link
Contributor

@davidroth davidroth commented Sep 7, 2021 •
edited
Loading

See: #608

@leezen
Copy link
Contributor

leezen commented Oct 13, 2021

@davidroth Sorry for not replying sooner. Since this is a multi-language component, you should be able to automatically generate the appropriate SDKs. Note that the schema is actually generated from a Go program (see provider/cmd/pulumi-gen-eks) so if you modify that along with modifying the underlying provider itself (as you've done w/ the .ts files), then you should be able to run make build to generate the other language SDKs as part of this PR.

@davidroth
Copy link
Contributor Author

@leezen Ok, I updated provider/cmd/pulumi-gen-eks\main.go and generated the files for the dotnet python and go providers.
Please let me know if anything is missing.

@github-actions
Copy link

github-actions bot commented Nov 9, 2021

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@davidroth
Copy link
Contributor Author

Rebased, fixed linting error + updated changelog.

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@davidroth
Copy link
Contributor Author

@lblackstone Any chance of somebody reviewing this so that it can go into the 0.36 release?

@lblackstone
Copy link
Member

@lblackstone Any chance of somebody reviewing this so that it can go into the 0.36 release?

Thanks for the PR! I just added it to our review queue so we'll take a look shortly.

lblackstone
lblackstone requested changes Nov 11, 2021
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

nodejs/eks/cmd/provider/cni.ts Outdated Show resolved Hide resolved
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@lblackstone
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/1449832011

@lblackstone lblackstone merged commit e037514 into pulumi:master Nov 11, 2021
@davidroth davidroth mentioned this pull request Apr 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone approved these changes

@viveklak viveklak Awaiting requested review from viveklak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davidroth @leezen @lblackstone