Ensure that externalSnat and cniExternalSnat don't cause a conflict #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
stack72
added
the
impact/no-changelog-required
lblackstone
reviewed
Jul 29, 2022
Comment on lines
+149
to
+154
| if (args.externalSnat) { | ||
| env.push({ name: "AWS_VPC_K8S_CNI_EXTERNALSNAT", value: args.externalSnat ? "true" : "false" }); | ||
| } else if (args.cniExternalSnat) { |
There was a problem hiding this comment.
Should externalSnat always take precedence, or would it be better to return an error if they're both set?
There was a problem hiding this comment.
Agree - we should probably check and error if both are specified instead of encoding an implicit preference.
Does the PR have any schema changes?Looking good! No breaking changes found. |
lblackstone
approved these changes
Jul 29, 2022
Does the PR have any schema changes?Looking good! No breaking changes found. |
viveklak
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #624
Proposed changes
Related issues (optional)