Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LaunchTemplateTagSpecifications to NodeGroupV2 #810

Merged
merged 2 commits into from
Nov 11, 2022
Merged

Add LaunchTemplateTagSpecifications to NodeGroupV2 #810

merged 2 commits into from
Nov 11, 2022

Conversation

MMartyn
Copy link
Contributor

@MMartyn MMartyn commented Nov 9, 2022

Proposed changes

Gives ability to set launch template tags on the launch template created in NodeGroupV2

Related issues (optional)

Closes #808

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

lblackstone
lblackstone requested changes Nov 11, 2022
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @MMartyn! This looks great overall, but let's exercise the new option in a test just to make sure it's working end-to-end.

You can add an example tag to the nodeGroup test.

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting.
Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@MMartyn
Copy link
Contributor Author

MMartyn commented Nov 11, 2022

Good to go now.

@lblackstone
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

Please view the PR build - https://github.com/pulumi/pulumi-eks/actions/runs/3448166293

lblackstone
lblackstone approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just checking to make sure that CI tests pass now.

@lblackstone lblackstone merged commit ff52acd into pulumi:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add LaunchTemplateTagSpecifications to NodeGroupV2
2 participants
@MMartyn @lblackstone