Fix worker node AMI regex to use a version that matches control plane version, or the latest / default AMI published #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metral
force-pushed
the
rm-regex-fix-tests
branch
from
28f782e
to
1f2c8b2
Compare
lukehoban
approved these changes
Mar 29, 2019
| name: "name", | ||
| values: [ "amazon-eks-node-" + version + "*" ], | ||
| name: "description", | ||
| values: [ "*k8s*" + version + "*" ], |
There was a problem hiding this comment.
Does this approach of having two filters on description work? I assume so since you’ve tried this - but I hadn’t expected it would.
There was a problem hiding this comment.
Yup, you can apparently chain them: https://gist.github.com/metral/4ba5cfe72fffe3c30dc0a57cbd08bd97
metral
force-pushed
the
rm-regex-fix-tests
branch
from
1f2c8b2
to
e4ee48f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.