Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform-provider-fastly to v4.3.2 #252

Closed
wants to merge 2 commits into from

Conversation

aq17
Copy link
Contributor

@aq17 aq17 commented May 2, 2023

This PR was generated via $ upgrade-provider pulumi-fastly.


Upgrading from 4.3.0 to 4.3.2.
Upgrading pulumi-terraform-bridge from v3.44.3 to v3.45.3.

Fixes #251
Fixes #247

@aq17 aq17 self-assigned this May 2, 2023
@aq17 aq17 requested a review from a team May 2, 2023 18:28
@github-actions
Copy link

github-actions bot commented May 2, 2023

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

@aq17 aq17 changed the title Upgrade terraform-provider- to v4.3.2 Upgrade terraform-provider-fastly to v4.3.2 May 2, 2023
@t0yv0
Copy link
Member

t0yv0 commented May 4, 2023

Curious why this is broken @aq17 ?

Error: index.ts(17,44): error TS2345: Argument of type '{ backends: { address: string; name: string; port: number; }[]; domains: { comment: string; name: string; }[]; forceDestroy: true; }' is not assignable to parameter of type 'ServiceVclArgs'.
[250](https://github.com/pulumi/pulumi-fastly/actions/runs/4864539477/jobs/8673819149#step:22:252)
    Property 'name' is missing in type '{ backends: { address: string; name: string; port: number; }[]; domains: { comment: string; name: string; }[]; forceDestroy: true; }' but required in type 'ServiceVclArgs'.
[251](https://github.com/pulumi/pulumi-fastly/actions/runs/4864539477/jobs/8673819149#step:22:253)
  
[252](https://github.com/pulumi/pulumi-fastly/actions/runs/4864539477/jobs/8673819149#step:22:254)
  Resources:
[253](https://github.com/pulumi/pulumi-fastly/actions/runs/4864539477/jobs/8673819149#step:22:255)
      + 1 to create

Perhaps this is the Autonaming malfunction fixed in pulumi/pulumi-terraform-bridge#1064 ?

@aq17
Copy link
Contributor Author

aq17 commented May 4, 2023

@t0yv0 looks like it, will try again with new bridge version

@aq17
Copy link
Contributor Author

aq17 commented May 4, 2023

closed in favor of #253

@aq17 aq17 closed this May 4, 2023
@aq17 aq17 deleted the upgrade-terraform-provider--to-v4.3.2 branch May 4, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-fastly to v4.3.2 Upgrade terraform-provider-fastly to v4.3.1
2 participants