Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to upstream v2.3.0 #119

Merged
merged 3 commits into from
Apr 2, 2019
Merged

Update to upstream v2.3.0 #119

merged 3 commits into from
Apr 2, 2019

Conversation

jen20
Copy link
Contributor

@jen20 jen20 commented Apr 1, 2019

Update to v2.3.0 of the Google Beta Terraform Provider.

@jen20 jen20 requested review from lukehoban and joeduffy April 1, 2019 16:29
* },
* ],
* });
* ```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why this happens? I see this sometimes in my own diffs (losing tf2pulumi examples)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually some kind of error has been introduced into the HCL when we lose an example like this - I'll open a new issue to track them down and see about recovering them.

Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jen20 jen20 merged commit 3e07d81 into master Apr 2, 2019
@pulumi-bot pulumi-bot deleted the jen20/update-to-v2.3.0 branch April 2, 2019 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants