Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to override a managed by description #134

Merged

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Apr 8, 2019

Fixes: #93

This introduces the work to allow a resource to override a "Managed
by Terraform" description

Fixes: pulumi#93

This introduces the work to allow a resource to override a "Managed
by Terraform" description
@jen20 jen20 added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Apr 8, 2019
@jen20
Copy link
Contributor

jen20 commented Apr 8, 2019

This build is failing because of

- openssl aes-256-cbc -K $encrypted_289ace6c29ed_key -iv $encrypted_289ace6c29ed_iv -in gcp-credentials.json.enc -out gcp-credentials.json -d
- in a fork, the secret is unavailable. We need to modify the build script here to test whether we're in a fork or not before attempting, and just skip anything requiring credentials if so.

@jen20 jen20 merged commit f5e5bdd into pulumi:master Apr 8, 2019
@joeduffy
Copy link
Member

joeduffy commented Apr 8, 2019

This is awesome, LGTM 👍, thanks @stack72.

@stack72 stack72 deleted the override-default-description-managed-zone branch April 8, 2019 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants