Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade terraform provider google beta to v5.20.0 #1824

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Mar 13, 2024

Fixes #1816

The automated upgrade-provider job failed because several new resources did not have docs auto-discovered. These are now workaround by listing these resources as OK to proceed without docs.

error: failed to gather package metadata: problem gathering resources: 3 errors occurred:
	* could not find docs for resource 'google_clouddeploy_custom_target_type_iam_binding'. Override the Docs property in the resource mapping. See type tfbridge.DocInfo for details.
	* could not find docs for resource 'google_clouddeploy_custom_target_type_iam_member'. Override the Docs property in the resource mapping. See type tfbridge.DocInfo for details.
	* could not find docs for resource 'google_clouddeploy_custom_target_type_iam_policy'. Override the Docs property in the resource mapping. See type tfbridge.DocInfo for details.
	

Diving a bit deeper there is a strange pattern where three resources are documented in a single markdown file (and shown on a single page in TF registry), this one:

./upstream/website/docs/r/clouddeploy_custom_target_type_iam.html.markdown

The file itself does not correspond to any one of these resources but to all three together. We don't yet support this pattern but we could experiment with broadcasting this file as the "source" for every three resources and see how that projects into the docs.

@t0yv0 t0yv0 requested a review from corymhall March 13, 2024 15:46
Copy link

Does the PR have any schema changes?

Does the PR have any schema changes?

Found 8 breaking changes:

Types

  • 🟢 "gcp:compute/ServiceAttachmentConsumerAcceptList:ServiceAttachmentConsumerAcceptList": required: "projectIdOrNum" property is no longer Required
  • 🟢 "gcp:compute/getInstanceGroupManagerInstanceLifecyclePolicy:getInstanceGroupManagerInstanceLifecyclePolicy": required: "defaultActionOnFailure" property has changed to Required
  • "gcp:kms/CryptoKeyVersionAttestationCertChains:CryptoKeyVersionAttestationCertChains": properties:
    • 🟡 "caviumCerts" type changed from "string" to "array":
      • 🟡 items had no type but now has &{Type:string Ref: AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false}
    • 🟡 "googleCardCerts" type changed from "string" to "array":
      • 🟡 items had no type but now has &{Type:string Ref: AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false}
    • 🟡 "googlePartitionCerts" type changed from "string" to "array":
      • 🟡 items had no type but now has &{Type:string Ref: AdditionalProperties: Items: OneOf:[] Discriminator: Plain:false}

New resources:

  • clouddeploy/customTargetTypeIamBinding.CustomTargetTypeIamBinding
  • clouddeploy/customTargetTypeIamMember.CustomTargetTypeIamMember
  • clouddeploy/customTargetTypeIamPolicy.CustomTargetTypeIamPolicy

New functions:

  • clouddeploy/getCustomTargetTypeIamPolicy.getCustomTargetTypeIamPolicy

Maintainer note: consult the runbook for dealing with any breaking changes.

@t0yv0 t0yv0 requested a review from iwahbe March 13, 2024 17:02
Copy link
Member

@iwahbe iwahbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t0yv0
Copy link
Member Author

t0yv0 commented Mar 13, 2024

/release minor

@t0yv0 t0yv0 merged commit 62d279c into master Mar 13, 2024
18 checks passed
@t0yv0 t0yv0 deleted the upgrade-terraform-provider-google-beta-to-v5.20.0 branch March 13, 2024 18:57
@github-actions github-actions bot added needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 and removed needs-release/minor When a PR with this label merges, it initiates a release of vX.Y+1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade terraform-provider-google-beta to v5.20.0
2 participants