-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make go tests run out of the box #1949
Conversation
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
Is README.md missing any configuration options?
Please add a description for each of these options to |
if os.Getenv("PULUMI_GO_DEP_ROOT") == "" { | ||
depRoot := getCwd(t) + "/../../" | ||
err := os.Setenv("PULUMI_GO_DEP_ROOT", depRoot) | ||
require.NoError(t, err) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you point to where we consume this env var? We don't set it in .ci-mgmt and I can't find it used anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defined here:
PULUMI_GO_DEP_ROOT: ${{ github.workspace }}/.. |
Go tests require a magic env var to run, this PR sets it by default in the go base options.