Skip to content

Commit

Permalink
Remove validateOnly from SDKs and resource URLs (#866)
Browse files Browse the repository at this point in the history
Previously, validateOnly was a property of the eventarc.Trigger resource (and some others). However, this property is an API implementation detail: API client may specify it to get a "dry run" without the actual action. See https://google.aip.dev/163#guidance

This PR ignores all query parameters with this specific name while building SDKs and resource URLs. As a result, we will never set it and it will stay false by default.

Fix #865
  • Loading branch information
mikhailshilkov committed Apr 27, 2023
1 parent 5d84564 commit 6163124
Show file tree
Hide file tree
Showing 244 changed files with 113 additions and 4,576 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@ CHANGELOG

## HEAD (Unreleased)

Bug fixes:

- Remove `validateOnly` query parameter from SDK properties
[#865](https://github.com/pulumi/pulumi-google-native/issues/865)

## v0.30.0 (2023-04-14)
Upstream breaking changes:
- Resource "google-native:sqladmin/v1beta4:Instance" missing input "availableMaintenanceVersions"
Expand Down
Loading

0 comments on commit 6163124

Please sign in to comment.