Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen ignores Secret flag on properties with prompt types #420

Closed
Tracked by #598
t0yv0 opened this issue Apr 19, 2022 · 2 comments 路 Fixed by #639
Closed
Tracked by #598

Codegen ignores Secret flag on properties with prompt types #420

t0yv0 opened this issue Apr 19, 2022 · 2 comments 路 Fixed by #639
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec language/java resolution/fixed This issue was fixed
Milestone

Comments

@t0yv0
Copy link
Member

t0yv0 commented Apr 19, 2022

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Currently in providers such as AWS we have properties that are specified as secret, but are projected by codegen into promptly typed (not Output<T>-wrapped) accessors. As a result there is no guarantee that consuming code understands they are secret. We should fix this, including a breaking change to project these properties as Output<T>-wrapped properties so we can set the secret flag on them.

Since #414 this is a codegen warning but we can tighten to an error and fix for practical cases.

Affected area/feature

@t0yv0 t0yv0 added the kind/bug Some behavior is incorrect or out of spec label Apr 19, 2022
@t0yv0 t0yv0 mentioned this issue Apr 19, 2022
3 tasks
@t0yv0
Copy link
Member Author

t0yv0 commented May 17, 2022

NOTE to self: compare to what happens in other languages to decide what to do here.

@t0yv0 t0yv0 self-assigned this May 24, 2022
@mikhailshilkov mikhailshilkov added this to the 0.73 milestone May 24, 2022
@t0yv0 t0yv0 mentioned this issue May 31, 2022
3 tasks
@t0yv0
Copy link
Member Author

t0yv0 commented May 31, 2022

The underlying issue promoted to pulumi/pulumi#9744 as it affects more than just Java. For this issue I suggest we close with the attached PR that tightens the warning for now.

@t0yv0 t0yv0 closed this as completed in #639 Jun 1, 2022
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec language/java resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants