Revamp config support #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
added
the
impact/no-changelog-required
pawelprazak
suggested changes
Apr 19, 2022
sdk/jvm/pulumi/src/main/java/com/pulumi/core/internal/Codegen.java
Outdated
Show resolved
Hide resolved
sdk/jvm/pulumi/src/main/java/com/pulumi/core/internal/Codegen.java
Outdated
Show resolved
Hide resolved
sdk/jvm/pulumi/src/main/java/com/pulumi/core/internal/Codegen.java
Outdated
Show resolved
Hide resolved
sdk/jvm/pulumi/src/main/java/com/pulumi/core/internal/Codegen.java
Outdated
Show resolved
Hide resolved
sdk/jvm/pulumi/src/main/java/com/pulumi/core/internal/Codegen.java
Outdated
Show resolved
Hide resolved
| return enumTypes | ||
| } | ||
|
|
||
| func (dg *defaultsGen) unEitherTypeShape(typeShape TypeShape) (bool, TypeShape, TypeShape) { |
There was a problem hiding this comment.
those un*TypeShape(...) look like they should be on the TypeShape itself, this one esp. looks useful for #138
...egen/testing/test/testdata/mini-awsnative/jvm/src/main/java/com/pulumi/awsnative/Config.java
Show resolved
Hide resolved
sdk/jvm/pulumi/src/main/java/com/pulumi/core/internal/Codegen.java
Outdated
Show resolved
Hide resolved
pawelprazak
reviewed
Apr 19, 2022
sdk/jvm/pulumi/src/main/java/com/pulumi/core/internal/Codegen.java
Outdated
Show resolved
Hide resolved
|
I'm doing a PR to this PR to help out with the Java part, and better understand limitations of our Environment and Config implementations we have right now. |
|
instead of making you do the changes from my review please take this one :) |
Code review for #414
|
Filed #420 bug discovered here. Also noting that Union and Either handling is a little sketchy, but at least seems to produce compiling code for now. We may need to revisit. There's a few further simplifications this opens up, including removing |
t0yv0
added a commit
that referenced
this pull request
May 3, 2022
* Rebasing * Merging testdata * Add mini-azuread test case * Fix merge * Fix handling secret outputs * Accept changes * Fix generation of custom-named props like public_ * Implement secret() helper * [codegen] built and added added providers/pulumi-aws-native/ * [codegen] built and added added providers/pulumi-aws/ * [codegen] built and added added providers/pulumi-azure-native/ * [codegen] built and added added providers/pulumi-docker/ * [codegen] built and added added providers/pulumi-eks/ * [codegen] built and added added providers/pulumi-gcp/ * [codegen] built and added added providers/pulumi-google-native/ * [codegen] built and added added providers/pulumi-kubernetes/ * Pass lint * Code style improvements and cleanup Co-authored-by: Paweł Prażak <pprazak@virtuslab.com>
t0yv0
added a commit
that referenced
this pull request
May 3, 2022
* Rebasing * Merging testdata * Add mini-azuread test case * Fix merge * Fix handling secret outputs * Accept changes * Fix generation of custom-named props like public_ * Implement secret() helper * [codegen] built and added added providers/pulumi-aws-native/ * [codegen] built and added added providers/pulumi-aws/ * [codegen] built and added added providers/pulumi-azure-native/ * [codegen] built and added added providers/pulumi-docker/ * [codegen] built and added added providers/pulumi-eks/ * [codegen] built and added added providers/pulumi-gcp/ * [codegen] built and added added providers/pulumi-google-native/ * [codegen] built and added added providers/pulumi-kubernetes/ * Pass lint * Code style improvements and cleanup Co-authored-by: Paweł Prażak <pprazak@virtuslab.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Checklist