Change getId() to id()

[mikhailshilkov]

Hello!

• Vote on this issue by adding a 👍 reaction
• If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

We renamed all property getters to remove get from the name, but forgot to do the same for the getId() method:

pulumi-java/sdk/java/pulumi/src/main/java/com/pulumi/resources/CustomResource.java

Lines 94 to 96 in 5cd9786

	public Output<String> getId() {
	return this.id;
	}

We should go ahead and do that. It's a breaking change but we now is the best time we can do it yet.

Affected area/feature

[pawelprazak]

FYI this might require docs, example and templates changes.

[mikhailshilkov]

Sure, that's reasonable

[pawelprazak]

As it turns out this impacts codegen with the name collisions, will adjust the codegen accordingly.

[pawelprazak]

Note to self, remember to remove in follow up:

• deprecated old getters (left in place for backward compatibility)
• remove old getter names from isReservedResourceMethod in codegen

[pawelprazak]

Added a follow up issue to cleanup the deprecated methods: #769