Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover replaceOnChanges with a test #82

Closed
Tracked by #598
t0yv0 opened this issue Feb 8, 2022 · 0 comments 路 Fixed by #686
Closed
Tracked by #598

Cover replaceOnChanges with a test #82

t0yv0 opened this issue Feb 8, 2022 · 0 comments 路 Fixed by #686
Assignees
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone

Comments

@t0yv0
Copy link
Member

t0yv0 commented Feb 8, 2022

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

Resource option replaceOnChanges functionality does not seem to be covered by tests, it would be great to add.

We unfortunately do not seem to have good prior art of testing it in pulumi/pulumi.

I found this: sdk/nodejs/tests/runtime/langhost/cases/066.replace_on_changes/index.js

Technically what we're testing here is that:

  • the user can express replaceOnChanges option
  • and in it propagates as such to the engine

So perhaps we can get a way with a mocks-based test that only exercises the SDK, though a full integration test is also an option here.

Affected area/feature

@t0yv0 t0yv0 added the kind/enhancement Improvements or new features label Feb 8, 2022
@t0yv0 t0yv0 mentioned this issue Feb 8, 2022
3 tasks
@t0yv0 t0yv0 mentioned this issue Jun 2, 2022
40 tasks
@t0yv0 t0yv0 added this to the 0.74 milestone Jun 7, 2022
pawelprazak added a commit that referenced this issue Jun 20, 2022
pawelprazak added a commit that referenced this issue Jun 29, 2022
pawelprazak added a commit that referenced this issue Jun 30, 2022
@mikhailshilkov mikhailshilkov modified the milestones: 0.74, 0.75 Jul 1, 2022
pawelprazak added a commit that referenced this issue Jul 8, 2022
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants