Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support all languages #77

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Support all languages #77

merged 2 commits into from
Aug 12, 2020

Conversation

lukehoban
Copy link
Member

Fixes #40.

justinvp
justinvp approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

pkg/controller/stack/stack_controller.go Outdated Show resolved Hide resolved
metral
metral approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@metral metral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

The only ask would be to add a test for each of the new languages. Here's an example in the controller suite test. Happy to push this out to another issue/PR in the interest of time

@lukehoban
Copy link
Member Author

The only ask would be to add a test for each of the new languages. Here's an example in the controller suite test. Happy to push this out to another issue/PR in the interest of time

Yeah - definitely would love to add tests here - but just started looking at that and appears there's a fairly complex custom test framework here I'll have to learn (and which I have not yet been able to run locally) - so will open an issue to do that as a fast follow-up.

This was referenced Aug 11, 2020
Open
Open
@lukehoban
Copy link
Member Author

will open an issue to do that as a fast follow-up.

#80

@lukehoban lukehoban merged commit 1ff3360 into master Aug 12, 2020
@pulumi-bot pulumi-bot deleted the lukehoban/languages branch August 12, 2020 00:14
metral added a commit that referenced this pull request Aug 12, 2020
@metral
Remove TODOs
29ab7bf 
TODOs closed in #77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metral metral metral approved these changes

@justinvp justinvp justinvp approved these changes

@viveklak viveklak viveklak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support other languages in InstallProjectDependencies
4 participants
@lukehoban @justinvp @viveklak @metral