Read live Job state for replaceUnready check (#1578)

The check added in de129e3 mistakenly did not check the
live status of the Job, but instead checked the user inputs.
This would lead to erroneous replacements for ready Jobs.

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 - Allow opting out of CRD rendering for Helm v3 by specifying `SkipCRDRendering` argument to Helm charts. (https://github.com/pulumi/pulumi-kubernetes/pull/1572)
 - Add replaceUnready annotation for Jobs. (https://github.com/pulumi/pulumi-kubernetes/pull/1575)
+- Read live Job state for replaceUnready check. (https://github.com/pulumi/pulumi-kubernetes/pull/1578)
 
 ## 3.1.2 (May 12, 2021)
 

provider/pkg/provider/provider.go

@@ -1372,13 +1372,16 @@ func (k *kubeProvider) Diff(
 	if metadata.ReplaceUnready(newInputs) {
 		switch newInputs.GetKind() {
 		case "Job":
-			jobChecker := states.NewJobChecker()
-			job, err := clients.FromUnstructured(newInputs)
-			if err == nil {
-				jobChecker.Update(job)
-				if !jobChecker.Ready() {
-					hasChanges = pulumirpc.DiffResponse_DIFF_SOME
-					replaces = append(replaces, `.metadata.annotations["pulumi.com/replaceUnready"]`)
+			// Fetch current Job status and check point-in-time readiness. Errors are ignored.
+			if live, err := k.readLiveObject(newInputs); err == nil {
+				jobChecker := states.NewJobChecker()
+				job, err := clients.FromUnstructured(live)
+				if err == nil {
+					jobChecker.Update(job)
+					if !jobChecker.Ready() {
+						hasChanges = pulumirpc.DiffResponse_DIFF_SOME
+						replaces = append(replaces, `.metadata.annotations["pulumi.com/replaceUnready"]`)
+					}
 				}
 			}
 		default: