Skip to content

Commit

Permalink
Detect namespace diff for first-class providers. (#674)
Browse files Browse the repository at this point in the history
When DiffConfig was implemented, the namespace parameter
was overlooked, which would cause changes to the namespace
parameter to be ignored after creation.
  • Loading branch information
lblackstone committed Aug 2, 2019
1 parent 37aea09 commit 7204d33
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

- Fall back to client-side diff if server-side diff fails. (https://github.com/pulumi/pulumi-kubernetes/pull/685).
- Fix namespace arg for Python Helm SDK (https://github.com/pulumi/pulumi-kubernetes/pull/670).
- Detect namespace diff for first-class providers. (https://github.com/pulumi/pulumi-kubernetes/pull/674).
- Fix values arg for Python Helm SDK (https://github.com/pulumi/pulumi-kubernetes/pull/678).
- Fix Python Helm LocalChartOpts to inherit from BaseChartOpts (https://github.com/pulumi/pulumi-kubernetes/pull/681).

Expand Down
3 changes: 3 additions & 0 deletions pkg/provider/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,9 @@ func (k *kubeProvider) DiffConfig(ctx context.Context, req *pulumirpc.DiffReques
if olds["cluster"] != news["cluster"] {
diffs = append(diffs, "cluster")
}
if olds["namespace"] != news["namespace"] {
diffs = append(diffs, "namespace")
}
if olds["enableDryRun"] != news["enableDryRun"] {
diffs = append(diffs, "enableDryRun")
}
Expand Down

0 comments on commit 7204d33

Please sign in to comment.