Skip to content

Commit

Permalink
Fix detailed diff for server-side apply (#1873)
Browse files Browse the repository at this point in the history
Previously, the provider was erroneously setting all detailed diffs
to the InputDiff mode, which ignored the changes previewed on
the API server. This changes the diff to use the InputDiff value
computed for each property.
  • Loading branch information
lblackstone committed Jan 21, 2022
1 parent 23e891d commit a6787cc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
## HEAD (Unreleased)

- Fix detailed diff for server-side apply (https://github.com/pulumi/pulumi-kubernetes/pull/1873)

## 3.14.1 (January 18, 2022)

- Disable last-applied-configuration annotation for replaced CRDs (https://github.com/pulumi/pulumi-kubernetes/pull/1868)
Expand Down
3 changes: 0 additions & 3 deletions provider/pkg/provider/provider.go
Original file line number Diff line number Diff line change
Expand Up @@ -1531,9 +1531,6 @@ func (k *kubeProvider) Diff(ctx context.Context, req *pulumirpc.DiffRequest) (*p
"converting JSON patch describing resource changes to a diff",
newInputs.GetNamespace(), newInputs.GetName())
}
for _, v := range detailedDiff {
v.InputDiff = true
}

for k, v := range detailedDiff {
switch v.Kind {
Expand Down

0 comments on commit a6787cc

Please sign in to comment.