Address feedback

provider/cmd/pulumi-resource-kubernetes/schema.json

@@ -444,7 +444,7 @@
             },
             "enableServerSideApply": {
                 "type": "boolean",
-                "description": "If present and set to true, enable Server-Side Apply mode.\nSee https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details."
+                "description": "If present and set to false, disable Server-Side Apply mode.\nSee https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details."
             },
             "kubeconfig": {
                 "type": "string",
@@ -57864,7 +57864,7 @@
             },
             "enableServerSideApply": {
                 "type": "boolean",
-                "description": "If present and set to true, enable Server-Side Apply mode.\nSee https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.",
+                "description": "If present and set to false, disable Server-Side Apply mode.\nSee https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.",
                 "defaultInfo": {
                     "environment": [
                         "PULUMI_K8S_ENABLE_SERVER_SIDE_APPLY"

provider/pkg/gen/schema.go

@@ -78,7 +78,7 @@ func PulumiSchema(swagger map[string]interface{}) pschema.PackageSpec {
 					DeprecationMessage: "This option has been replaced by `enableServerSideApply`.",
 				},
 				"enableServerSideApply": {
-					Description: "If present and set to true, enable Server-Side Apply mode.\nSee https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.",
+					Description: "If present and set to false, disable Server-Side Apply mode.\nSee https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.",
 					TypeSpec:    pschema.TypeSpec{Type: "boolean"},
 				},
 				"enableReplaceCRD": {
@@ -157,7 +157,7 @@ func PulumiSchema(swagger map[string]interface{}) pschema.PackageSpec {
 							"PULUMI_K8S_ENABLE_SERVER_SIDE_APPLY",
 						},
 					},
-					Description: "If present and set to true, enable Server-Side Apply mode.\nSee https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.",
+					Description: "If present and set to false, disable Server-Side Apply mode.\nSee https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.",
 					TypeSpec:    pschema.TypeSpec{Type: "boolean"},
 				},
 				"enableReplaceCRD": {

provider/pkg/provider/provider.go

@@ -401,6 +401,8 @@ func (k *kubeProvider) Configure(_ context.Context, req *pulumirpc.ConfigureRequ
 		CurrentContext: vars["kubernetes:config:context"],
 	}
 
+	// TODO: Simplify / factor out the provider flag parsing. Currently lots of error-prone copy-paste code here.
+
 	deleteUnreachable := func() bool {
 		// If the provider flag is set, use that value to determine behavior. This will override the ENV var.
 		if enabled, exists := vars["kubernetes:config:deleteUnreachable"]; exists {
@@ -442,7 +444,6 @@ func (k *kubeProvider) Configure(_ context.Context, req *pulumirpc.ConfigureRequ
 		if enabled, exists := os.LookupEnv("PULUMI_K8S_ENABLE_SERVER_SIDE_APPLY"); exists {
 			return enabled == trueStr
 		}
-		// Default to true.
 		return true
 	}
 	if enableServerSideApply() {

sdk/dotnet/Config/Config.cs

@@ -99,7 +99,7 @@ public void Set(T value)
 
         private static readonly __Value<bool?> _enableServerSideApply = new __Value<bool?>(() => __config.GetBoolean("enableServerSideApply"));
         /// <summary>
-        /// If present and set to true, enable Server-Side Apply mode.
+        /// If present and set to false, disable Server-Side Apply mode.
         /// See https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.
         /// </summary>
         public static bool? EnableServerSideApply

sdk/dotnet/Provider.cs

@@ -88,7 +88,7 @@ public sealed class ProviderArgs : global::Pulumi.ResourceArgs
         public Input<bool>? EnableReplaceCRD { get; set; }
 
         /// <summary>
-        /// If present and set to true, enable Server-Side Apply mode.
+        /// If present and set to false, disable Server-Side Apply mode.
         /// See https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.
         /// </summary>
         [Input("enableServerSideApply", json: true)]

sdk/java/src/main/java/com/pulumi/kubernetes/Config.java

@@ -59,7 +59,7 @@ public Optional<Boolean> enableReplaceCRD() {
         return Codegen.booleanProp("enableReplaceCRD").config(config).get();
     }
 /**
- * If present and set to true, enable Server-Side Apply mode.
+ * If present and set to false, disable Server-Side Apply mode.
  * See https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.
  * 
  */

sdk/java/src/main/java/com/pulumi/kubernetes/ProviderArgs.java

@@ -136,15 +136,15 @@ public Optional<Output<Boolean>> enableReplaceCRD() {
     }
 
     /**
-     * If present and set to true, enable Server-Side Apply mode.
+     * If present and set to false, disable Server-Side Apply mode.
      * See https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.
      * 
      */
     @Import(name="enableServerSideApply", json=true)
     private @Nullable Output<Boolean> enableServerSideApply;
 
     /**
-     * @return If present and set to true, enable Server-Side Apply mode.
+     * @return If present and set to false, disable Server-Side Apply mode.
      * See https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.
      * 
      */
@@ -471,7 +471,7 @@ public Builder enableReplaceCRD(Boolean enableReplaceCRD) {
         }
 
         /**
-         * @param enableServerSideApply If present and set to true, enable Server-Side Apply mode.
+         * @param enableServerSideApply If present and set to false, disable Server-Side Apply mode.
          * See https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.
          * 
          * @return builder
@@ -483,7 +483,7 @@ public Builder enableServerSideApply(@Nullable Output<Boolean> enableServerSideA
         }
 
         /**
-         * @param enableServerSideApply If present and set to true, enable Server-Side Apply mode.
+         * @param enableServerSideApply If present and set to false, disable Server-Side Apply mode.
          * See https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.
          * 
          * @return builder

sdk/nodejs/provider.ts

@@ -95,7 +95,7 @@ export interface ProviderArgs {
      */
     enableReplaceCRD?: pulumi.Input<boolean>;
     /**
-     * If present and set to true, enable Server-Side Apply mode.
+     * If present and set to false, disable Server-Side Apply mode.
      * See https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.
      */
     enableServerSideApply?: pulumi.Input<boolean>;

sdk/python/pulumi_kubernetes/provider.py

@@ -42,7 +42,7 @@ def __init__(__self__, *,
                2. The `PULUMI_K8S_ENABLE_CONFIGMAP_MUTABLE` environment variable.
         :param pulumi.Input[bool] enable_dry_run: Deprecated. If present and set to true, enable server-side diff calculations.
         :param pulumi.Input[bool] enable_replace_crd: Obsolete. This option has no effect.
-        :param pulumi.Input[bool] enable_server_side_apply: If present and set to true, enable Server-Side Apply mode.
+        :param pulumi.Input[bool] enable_server_side_apply: If present and set to false, disable Server-Side Apply mode.
                See https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.
         :param pulumi.Input['HelmReleaseSettingsArgs'] helm_release_settings: Options to configure the Helm Release resource.
         :param pulumi.Input['KubeClientSettingsArgs'] kube_client_settings: Options for tuning the Kubernetes client used by a Provider.
@@ -194,7 +194,7 @@ def enable_replace_crd(self, value: Optional[pulumi.Input[bool]]):
     @pulumi.getter(name="enableServerSideApply")
     def enable_server_side_apply(self) -> Optional[pulumi.Input[bool]]:
         """
-        If present and set to true, enable Server-Side Apply mode.
+        If present and set to false, disable Server-Side Apply mode.
         See https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.
         """
         return pulumi.get(self, "enable_server_side_apply")
@@ -336,7 +336,7 @@ def __init__(__self__,
                2. The `PULUMI_K8S_ENABLE_CONFIGMAP_MUTABLE` environment variable.
         :param pulumi.Input[bool] enable_dry_run: Deprecated. If present and set to true, enable server-side diff calculations.
         :param pulumi.Input[bool] enable_replace_crd: Obsolete. This option has no effect.
-        :param pulumi.Input[bool] enable_server_side_apply: If present and set to true, enable Server-Side Apply mode.
+        :param pulumi.Input[bool] enable_server_side_apply: If present and set to false, disable Server-Side Apply mode.
                See https://github.com/pulumi/pulumi-kubernetes/issues/2011 for additional details.
         :param pulumi.Input[pulumi.InputType['HelmReleaseSettingsArgs']] helm_release_settings: Options to configure the Helm Release resource.
         :param pulumi.Input[pulumi.InputType['KubeClientSettingsArgs']] kube_client_settings: Options for tuning the Kubernetes client used by a Provider.