Skip to content

Commit

Permalink
Fix Cluster/RoleBinding replace semantics
Browse files Browse the repository at this point in the history
Fixes #335.
  • Loading branch information
hausdorff committed Jan 4, 2019
1 parent aba4a95 commit c22af5f
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions pkg/provider/diff.go
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ var forceNew = groups{
// for compatibility purposes.
"core": core,
"": core,
"rbac.authorization.k8s.io": versions{
"v1alpha1": kinds{"ClusterRoleBinding": roleBinding, "RoleBinding": roleBinding},
"v1beta1": kinds{"ClusterRoleBinding": roleBinding, "RoleBinding": roleBinding},
"v1": kinds{"ClusterRoleBinding": roleBinding, "RoleBinding": roleBinding},
},
"storage.k8s.io": versions{
"v1": kinds{
"StorageClass": properties{
Expand Down Expand Up @@ -109,6 +114,8 @@ var job = properties{
".spec.template",
}

var roleBinding = properties{".roleRef"}

This comment has been minimized.

Copy link
@lukehoban

lukehoban Jan 4, 2019

Member

Nit - any reason we're formatting these differently for this one case?

This comment has been minimized.

Copy link
@hausdorff

hausdorff Jan 4, 2019

Author Contributor

No, we can do it the other way.


var statefulSet = properties{
".spec.podManagementPolicy",
".spec.revisionHistoryLimit",
Expand Down

0 comments on commit c22af5f

Please sign in to comment.