Use JSON schema when parsing YAML

The fields of the Kubernetes core resource types are tagged with Go's
`"json:"` serialization metadata. They expect things like JavaScript's
`Date` to be serialized as string.

Fixes #501.

CHANGELOG.md

@@ -12,6 +12,8 @@
     (https://github.com/pulumi/pulumi-kubernetes/pull/638).
 -   Return useful errors when we fail to fetch URL YAML
     (https://github.com/pulumi/pulumi-kubernetes/pull/638).
+-   Use JSON_SCHEMA when parsing Kubernetes YAML, to conform with the expectations of the Kubernetes
+    core resource types. (https://github.com/pulumi/pulumi-kubernetes/pull/638).
 
 ## 0.25.2 (July 11, 2019)
 

pkg/gen/nodejs-templates/yaml.ts.mustache

@@ -4,7 +4,6 @@
 import * as pulumi from "@pulumi/pulumi";
 import * as fs from "fs";
 import * as glob from "glob";
-import * as jsyaml from "js-yaml";
 import fetch from "node-fetch";
 import * as k8s from "../index";
 import * as outputApi from "../types/output";
@@ -66,6 +65,16 @@ import * as outputApi from "../types/output";
         resourcePrefix?: string;
     }
 
+    /** @ignore */ export function yamlLoadAll(text: string): any[] {
+        // NOTE[pulumi-kubernetes#501]: Use `loadAll` with `JSON_SCHEMA` here instead of
+        // `safeLoadAll` because the latter is incompatible with `JSON_SCHEMA`. It is
+        // important to use `JSON_SCHEMA` here because the fields of the Kubernetes core
+        // API types are all tagged with `json:`, and they don't deal very well with things
+        // like dates.
+        const jsyaml = require("js-yaml");
+        return jsyaml.loadAll(text, undefined, {schema: jsyaml.JSON_SCHEMA});
+    }
+
     /** @ignore */ export function parse(
         config: ConfigGroupOpts, opts?: pulumi.CustomResourceOptions
     ): pulumi.Output<{[key: string]: pulumi.CustomResource}> {
@@ -112,9 +121,8 @@ import * as outputApi from "../types/output";
             }
 
             for (const text of yamlTexts) {
-                const objs = jsyaml.safeLoadAll(text);
                 const docResources = parseYamlDocument({
-                        objs: objs,
+                        objs: yamlLoadAll(text),
                         transformations: config.transformations,
                         resourcePrefix: config.resourcePrefix
                     },
@@ -258,7 +266,7 @@ import * as outputApi from "../types/output";
             this.resources = pulumi.output(text.then(t => {
                 try {
                     return parseYamlDocument({
-                        objs: jsyaml.safeLoadAll(t),
+                        objs: yamlLoadAll(t),
                         transformations: config && config.transformations || [],
                         resourcePrefix: config && config.resourcePrefix || undefined
                     }, {parent: this})

sdk/nodejs/yaml/yaml.ts

@@ -4,7 +4,6 @@
 import * as pulumi from "@pulumi/pulumi";
 import * as fs from "fs";
 import * as glob from "glob";
-import * as jsyaml from "js-yaml";
 import fetch from "node-fetch";
 import * as k8s from "../index";
 import * as outputApi from "../types/output";
@@ -66,6 +65,16 @@ import * as outputApi from "../types/output";
         resourcePrefix?: string;
     }
 
+    /** @ignore */ export function yamlLoadAll(text: string): any[] {
+        // NOTE[pulumi-kubernetes#501]: Use `loadAll` with `JSON_SCHEMA` here instead of
+        // `safeLoadAll` because the latter is incompatible with `JSON_SCHEMA`. It is
+        // important to use `JSON_SCHEMA` here because the fields of the Kubernetes core
+        // API types are all tagged with `json:`, and they don't deal very well with things
+        // like dates.
+        const jsyaml = require("js-yaml");
+        return jsyaml.loadAll(text, undefined, {schema: jsyaml.JSON_SCHEMA});
+    }
+
     /** @ignore */ export function parse(
         config: ConfigGroupOpts, opts?: pulumi.CustomResourceOptions
     ): pulumi.Output<{[key: string]: pulumi.CustomResource}> {
@@ -112,9 +121,8 @@ import * as outputApi from "../types/output";
             }
 
             for (const text of yamlTexts) {
-                const objs = jsyaml.safeLoadAll(text);
                 const docResources = parseYamlDocument({
-                        objs: objs,
+                        objs: yamlLoadAll(text),
                         transformations: config.transformations,
                         resourcePrefix: config.resourcePrefix
                     },
@@ -2234,7 +2242,7 @@ import * as outputApi from "../types/output";
             this.resources = pulumi.output(text.then(t => {
                 try {
                     return parseYamlDocument({
-                        objs: jsyaml.safeLoadAll(t),
+                        objs: yamlLoadAll(t),
                         transformations: config && config.transformations || [],
                         resourcePrefix: config && config.resourcePrefix || undefined
                     }, {parent: this})