-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pulumi preview/up --diff for kubernetes resources does not display diffs of properties in the same level of nesting if one references a fully-encrypted resource by its name #1576
Comments
I think this issue may be specific to the k8s provider diffing, and could also be related to client-side preview. @bob-bins Do you see the same behavior if you use the enableDryRun Provider flag? |
same output when I enable that flag and run a preview after it is enabled |
Final findings (I also updated the ticket for proper steps to reproduce):
|
Ah, thanks for narrowing that down. I'm hoping that we will be able to fix this as a part of #1556 |
@lblackstone it looks like #1556 may be delayed. Wondering if it's possible to put a resource on this ticket, as literally every one of our production previews results in a useless diff since all of our services have at least one secret. |
Sorry for the delay. This is still high on the priority list, and I expect to continue work on it soon. |
Even when using server side diff (enabled manually), I'm still having this problem. To be clear, what is happening is this: I have a Because of this, the |
This is expected until #1659 is done. |
Just discovered that a workaround for this is wrapping the "non-secret" secret value in |
Any progress on this? Eagerly waiting for this specific feature. |
Any updates on this? We're seeing this (or a similar issue). The part that is making it hard to track down is that some manifests have no env var secret references, but still display this behavior? |
@aaronlevy It's still in progress, but my understanding is that you can use the The reason this is happening is fairly involved:
|
Fixed by #2445 |
Pulumi preview/up --diff does not display diffs of properties in the same level of nesting if one references a fully-encrypted resource by its name (or likely any other of its properties).
Expected behavior
If I change a deployment image I expect to see:
Current behavior
If I change a deployment image I actually see:
Steps to reproduce
Create these resources
Then change
"lolololo"
to any other string. See that the preview diff does not contain useful info.Then remove
secretRef: { name: secret.metadata.name },
. Apply the change. Then change the env var in the deployment again and see that the diff now displays correctlyWorkaround
Wrap the "false" secrets in
unsecret()
The text was updated successfully, but these errors were encountered: