Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm release uninstall should remove things in the release namespace #1744

Closed
viveklak opened this issue Oct 1, 2021 · 0 comments · Fixed by #1747
Closed

Helm release uninstall should remove things in the release namespace #1744

viveklak opened this issue Oct 1, 2021 · 0 comments · Fixed by #1747
Labels
area/helm helm-release-ga-blockers Items blocking Helm Release GA kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@viveklak
Copy link
Contributor

viveklak commented Oct 1, 2021

Hello!

  • Vote on this issue by adding a 👍 reaction
  • To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)

Issue details

This is a follow up to #1710 which was fixed in #1733. While install now uses the Helm Release's namespace for resources, uninstall needs to also have the namespace flow through. See comment here: #1733 (comment)

Steps to reproduce

  1. Use helm release to install charts with templates missing explicit namespace. (Use a namespace not created in the stack.)
  2. Ensure resources created in release's namespace
  3. pulumi destroy

Expected: All resources in helm release namespace deleted
Actual: Leaked resources in helm release's namespace.

@viveklak viveklak added kind/bug Some behavior is incorrect or out of spec area/helm helm-release-ga-blockers Items blocking Helm Release GA labels Oct 1, 2021
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm helm-release-ga-blockers Items blocking Helm Release GA kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants