Default to helm release's namespace for templates where ns unspecified

[viveklak]

Fix #1710

Curious to hear feedback on this approach.

Here we essentially set the kubeconfig used by helm to use the Helm Release's namespace. This means for namespaced objects created where namespace is not specified, the Helm Release's namespace is used. This is essentially the equivalent of helm template <chart> | kubectl create -n <helmrelease.namespace> -f -. This avoids having to use post render magic to manipulate templates. This also mirrors the behavior that Flux provides.

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[viveklak]

Could it be because get doesn't await the release operation correctly? Do we have no means to fetch resources from the Release resource itself? Or track its completion?

The id interpolate will wait on status.name and namespace which will only be set after the release is created. Its not an await issue since it seems to happen even if I hardcode the namespace/name. I might be doing something stupid like a typo. I will investigate further today.

Release delegates the resource creation to helm and so we don't have a great way to get child resources directly from it.

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[lblackstone]

Provider changes look reasonable. One question about the test.

[gitfool]

Curious to hear feedback on this approach.

Sounds like a great idea, especially if that's what flux does.

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[github-actions]

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

[gitfool]

@viveklak I took this for a test run and helm install with a namespace override works great! ⭐

However, when destroying the stack helm uninstall deleted the helm release but left resources behind for some charts like fluent bit where I was overriding the namespace. If instead I manually uninstall by specifying the namespace then it removes everything:

helm uninstall --namespace kube-system fluent-bit

So a tweak is needed to override the namespace for helm uninstall too.

[viveklak]

@viveklak I took this for a test run and helm install with a namespace override works great! ⭐

However, when destroying the stack helm uninstall deleted the helm release but left resources behind for some charts like fluent bit where I was overriding the namespace. If instead I manually uninstall by specifying the namespace then it removes everything:

helm uninstall --namespace kube-system fluent-bit

So a tweak is needed to override the namespace for helm uninstall too.

Thanks for the quick feedback @gitfool. Certainly makes sense and sorry for the oversight. Looks like we missed this in the tests since the namespace was created in the stack. Opened #1744 to track this.