Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm Release] Not working with private helm repos #1757

Closed
viveklak opened this issue Oct 5, 2021 · 2 comments 路 Fixed by #1824
Closed

[Helm Release] Not working with private helm repos #1757

viveklak opened this issue Oct 5, 2021 · 2 comments 路 Fixed by #1824
Assignees
Labels
helm-release-ga-blockers Items blocking Helm Release GA kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Milestone

Comments

@viveklak
Copy link
Contributor

viveklak commented Oct 5, 2021

Hello!

  • Vote on this issue by adding a 馃憤 reaction
  • To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already)

Copied from #1735 (comment)

Issue details

I tried using the new helm.Release but that does not seem to work with a private helm repo.

argo_args = helm.ReleaseArgs(
    chart="argocd",
    skip_await=False,
    namespace='argocd',
    values=values['argocd'],
    repository_opts=helm.RepositoryOptsArgs(
        repo=config.require('helm_repo'),
        username=config.require('helm_user'),
        password=config.require('helm_password')
    )
)
argo_release = helm.Release("argocd", args=argo_args)

This gives me the following error:

error: failed to pull chart: looks like "https://genuitysci.jfrog.io/artifactory/gorkubbe" is not a valid chart repository or cannot be reached: failed to fetch https://genuitysci.jfrog.io/artifactory/gorkubbe/index.yaml : 401 Unauthorized
This is using the same credentials that work with helm.Chart so they are not the problem
@viveklak viveklak added kind/bug Some behavior is incorrect or out of spec helm-release-ga-blockers Items blocking Helm Release GA labels Oct 5, 2021
@leezen leezen added the size/S Estimated effort to complete (1-2 days). label Oct 25, 2021
@infin8x infin8x added this to the 0.64 milestone Oct 26, 2021
@viveklak viveklak changed the title [Helm Release] Not working with private helm repos [Helm Release] Not working with private helm repos or local helm charts. Nov 9, 2021
@viveklak
Copy link
Contributor Author

viveklak commented Nov 9, 2021

Updated to include local helm charts in scope as well since I expect the fix to cover both.

@viveklak viveklak self-assigned this Nov 9, 2021
@lblackstone lblackstone assigned lblackstone and unassigned viveklak Nov 11, 2021
@mikhailshilkov mikhailshilkov modified the milestones: 0.64, 0.65 Nov 15, 2021
@lblackstone
Copy link
Member

I don't think the local chart not working is actually the same underlying problem. It appears that the current implementation doesn't consider local charts at all, but I'd guess that the private repo issue is related to credentials not being plumbed through correctly. It looks like #1732 is the local path issue, so I'll track progress there separately.

@lblackstone lblackstone changed the title [Helm Release] Not working with private helm repos or local helm charts. [Helm Release] Not working with private helm repos Nov 18, 2021
@mikhailshilkov mikhailshilkov modified the milestones: 0.65, 0.66 Dec 7, 2021
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-release-ga-blockers Items blocking Helm Release GA kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants