Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Helm/Release] Support local path #1732

Closed
cynial opened this issue Sep 27, 2021 · 3 comments · Fixed by #1809
Closed

[Helm/Release] Support local path #1732

cynial opened this issue Sep 27, 2021 · 3 comments · Fixed by #1809
Assignees
Labels
area/helm kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone

Comments

@cynial
Copy link

cynial commented Sep 27, 2021

Currently Helm/Chart support path:

		_, err := helmv3.NewChart(ctx, "wpdev", helmv3.ChartArgs{
			Path: pulumi.String("./hello"),
		})

But Helm/Release doesn't support:

		rel, err := helmv3.NewRelease(ctx, "test", &helmv3.ReleaseArgs{
                         // No Path args for Release
			RepositoryOpts: helmv3.RepositoryOptsArgs{
				Repo: pulumi.String("./hello"),
			},
		})
---
throw error:
          failed to pull chart: could not find protocol handler for:

Is it possible to support path for Helm/Release? Thanks.

@cynial cynial added the kind/enhancement Improvements or new features label Sep 27, 2021
@antifuchs
Copy link

In the helm release resource go code, it looks like if the chart name starts with a "/", it interprets the chart as a local file. However, RepositoryOpts are treated as mandatory (by the python SDK at least), so that won't work either (and passing an empty RepositoryOpts struct isn't accepted either.

@mikhailshilkov
Copy link
Member

@viveklak Is there a way forward here?

@lblackstone lblackstone changed the title [Helm/Release] Support path [Helm/Release] Support local path Nov 18, 2021
@lblackstone
Copy link
Member

There's no technical reason we can't support this. The current implementation appears to be making some bad assumptions, but it's fixable. I'll go ahead and pull this into the current milestone since I'm working on related code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants