Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Implement current "overlay" resources in the provider binary #1971

Open
14 of 29 tasks
Tracked by #2362
AaronFriel opened this issue Apr 20, 2022 · 4 comments
Open
14 of 29 tasks
Tracked by #2362
Assignees
Labels
kind/enhancement Improvements or new features kind/epic Large new features or investments mro1 Monica's list of 1st tier overlay related issues

Comments

@AaronFriel
Copy link
Member

AaronFriel commented Apr 20, 2022

The following resources are implemented as "overlay" resources, hand-written in each of our supported languages. This has increased the cost of supporting these resources and ensuring they handle resource options such as dependsOn.

These resource types are currently only available as overlays:

  • kubernetes:apiextensions.k8s.io:CustomResource
  • kubernetes:kustomize:Directory
  • kubernetes:yaml:ConfigFile
  • kubernetes:yaml:ConfigGroup

And the Helm Chart resources have an upgrade path via Helm/v3 Release:

  • kubernetes:helm.sh/v2:Chart
  • kubernetes:helm.sh/v3:Chart

Tasks

  1. kind/task resolution/fixed
    EronWright
  2. impact/no-changelog-required kind/bug language/dotnet
    EronWright
  3. area/codegen impact/no-changelog-required kind/enhancement language/dotnet
    EronWright
  4. 3 of 3
    kind/enhancement resolution/fixed
    EronWright
  5. 2 of 2
    kind/enhancement resolution/fixed
    EronWright
  6. area/yaml kind/bug resolution/fixed
    EronWright
  7. area/component-packages kind/enhancement needs-triage resolution/duplicate
  8. area/yaml kind/bug resolution/fixed resolution/wont-fix
    EronWright
  9. impact/no-changelog-required
    EronWright
  10. area/yaml kind/task resolution/fixed
    EronWright
  11. 3 of 20
    kind/enhancement
    EronWright
  12. 0 of 3
    kind/enhancement
  13. area/component-packages kind/enhancement size/M
  14. area/docs kind/bug language/java mro2
  15. 0 of 2
    kind/enhancement
  16. area/yaml blocked kind/bug
  17. EronWright

Resolves

  1. kind/enhancement mro1 resolution/fixed
    EronWright
  2. area/docs area/helm area/yaml kind/enhancement mro1
  3. area/sdk kind/engineering mro1
  4. area/sdk impact/usability kind/enhancement language/javascript mro2
  5. area/sdk kind/bug language/javascript mro2
  6. area/yaml kind/enhancement mro2
  7. kind/bug mro2 resolution/duplicate
    EronWright
  8. kind/question mro2 resolution/fixed
    EronWright
  9. kind/bug mro2
    EronWright
@EronWright

This comment was marked as outdated.

@lblackstone
Copy link
Member

master...lblackstone/mlc has a proof on concept for this work.

@mjeffryes mjeffryes changed the title Implement current "overlay" resources in the provider binary [Epic] Implement current "overlay" resources in the provider binary Jan 26, 2024
@mjeffryes mjeffryes added the kind/epic Large new features or investments label Feb 7, 2024
@geowalrus4gh
Copy link

geowalrus4gh commented Mar 8, 2024

Its really confusing. Document says CustomResource is supported by YAML runtime and even gave me an example.
image

Got this error

`      on Pulumi.yaml line 169:
     169:     type: kubernetes:apiextensions.k8s.io:CustomResource
    Error: error resolving type of resource resourceKarpenter: The resource type [kubernetes:apiextensions.k8s.io:CustomResource] is not supported in YAML at this time, see: https://github.com/pulumi/pulumi-kubernetes/issues/1971
      on Pulumi.yaml line 204:
     204:     type: kubernetes:apiextensions.k8s.io:CustomResource
`

@EronWright
Copy link
Contributor

EronWright commented Mar 8, 2024

@geowalrus4gh sorry, the documentation is incorrect. Please subscribe to this issue: #2787

An easy workaround would be to use the ConfigGroup resource, for example:

name: issue-1971
runtime: yaml
description: A minimal Kubernetes Pulumi YAML program
resources:
  example:
    type: kubernetes:yaml/v2:ConfigGroup
    properties:
      objs:
      - apiVersion: karpenter.sh/v1beta1
        kind: NodePool
        metadata:
          name: the-pool


@EronWright EronWright self-assigned this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features kind/epic Large new features or investments mro1 Monica's list of 1st tier overlay related issues
Projects
None yet
Development

No branches or pull requests

6 participants