Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically fall back to CSA mode for preview if SSA fails #2411

Closed
Tracked by #2362
lblackstone opened this issue May 16, 2023 · 0 comments
Closed
Tracked by #2362

Automatically fall back to CSA mode for preview if SSA fails #2411

lblackstone opened this issue May 16, 2023 · 0 comments
Assignees
Labels
area/server-side-apply kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Milestone

Comments

@lblackstone
Copy link
Member

lblackstone commented May 16, 2023

SSA mode requires additional permissions that may not be desirable at the preview stage. The provider should support a fallback to CSA mode for preview if the SSA preview fails without requiring an explicit provider configuration change.

Motivating comment from another issue follows:

For some background we want to be able to run CSA previews (never up commands, those will all be SSA) so that users / less privileged bots can preview changes without having to have full permissions to do everything they are proposing ([a real limit with k8s SSA](.(*mockPlmRepo))). This is because we want to only give deployment permissions to our CD system + oncall engineers. Non-oncall engineers will still be able to propose changes, but those changes will have to be reviewed before being merged into main and deployed via the CD system. Having a preview is itself a very helpful tool in the review process to make sure unintended changes aren't being made, but we can't safely run a SSA preview on unreviewed code.

We realize that there may be some diffs between the 2 systems regarding fields that are actually shared via SSA, but we would expect to see no diffs for fields managed entirely by pulumi.

Originally posted by @henry-fn in #2378 (comment)

Related: #2213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/server-side-apply kind/enhancement Improvements or new features resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

1 participant