Automatically fall back to client-side preview if server-side preview fails #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Found 2 breaking changes: |
… fails Server-side apply previews currently require "patch" permission to run. For cases where the user doesn't have permission to perform a "patch" operation, attempt a graceful fallback to Client-side preview. The Client-side preview may not be 100% accurate, but is preferable to failing with a permission error.
lblackstone
force-pushed
the
lblackstone/csa-fallback
branch
from
35298d9
to
0de9d61
Compare
lblackstone
changed the title
lblackstone
force-pushed
the
lblackstone/csa-fallback
branch
from
a99ab43
to
9cc2f8f
Compare
lblackstone
force-pushed
the
lblackstone/csa-fallback
branch
from
9cc2f8f
to
90850df
Compare
|
Without the provider change, the test fails with the following errors: |
kpitzen
approved these changes
May 23, 2023
rquitales
requested changes
May 23, 2023
rquitales
approved these changes
May 23, 2023
lblackstone
added a commit
that referenced
this pull request
Jul 14, 2023
… fails (#2419) Server-side apply previews currently require "patch" permission to run. For cases where the user doesn't have permission to perform a "patch" operation, attempt a graceful fallback to Client-side preview. The Client-side preview may not be 100% accurate, but is preferable to failing with a permission error.
lblackstone
added a commit
that referenced
this pull request
Jul 14, 2023
… fails (#2419) Server-side apply previews currently require "patch" permission to run. For cases where the user doesn't have permission to perform a "patch" operation, attempt a graceful fallback to Client-side preview. The Client-side preview may not be 100% accurate, but is preferable to failing with a permission error.
lblackstone
added a commit
that referenced
this pull request
Jul 17, 2023
… fails (#2419) Server-side apply previews currently require "patch" permission to run. For cases where the user doesn't have permission to perform a "patch" operation, attempt a graceful fallback to Client-side preview. The Client-side preview may not be 100% accurate, but is preferable to failing with a permission error.
|
Great job, just needed it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Server-side apply previews currently require "patch" permission to run. For cases where the user doesn't have permission to perform a "patch" operation, attempt a graceful fallback to Client-side preview. The Client-side preview may not be 100% accurate, but is preferable to failing with a permission error.
Related issues (optional)
Fix #2411