-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent change disabled python source distribution uploads, is this intended? #2540
Comments
Hi @edude03 our intention was to transition to the wheel-based distribution. We'll look into this shortly, we were not aware of the CC @rquitales |
@t0yv0 I'd be curious to understand how you intend to distribute the plugin using a wheel -- from what I can see the wheel doesn't actually include the resource plugin? |
That is correct. The source distribution does not include the plugin either, but auto-installs them upon Python project installation. This redundant (optional) with Pulumi CLI auto-installing the plugins upon pulumi preview/up. The best place to discuss this is in pulumi/pulumi#13709 I think. |
Note that v4.1.1 of the Kubernetes provider was released earlier that reverted this change. Closing this issue now but feel free to reopen should more discussion need to occur. |
This PR introduces the following changes: 1. pyproject.toml is generated for the Python SDK, replacing setup.py 2. during build, make python_sdk now builds a source distribution and a wheel using `python -m build` 3. when publishing to PyPI, both the wheel and the source distribution are expected to be published 4. packaging is wrapped in a dedicated venv to avoid modifying the outer Python environment Unlike the previous version that needed to be rolled back, (3) is now addressed, so #2540 does not reoccur. --------- Co-authored-by: Levi Blackstone <levi@pulumi.com>
What happened?
Not sure if this is a bug or intended behaviour, but this used to work and doesn't anymore and I can't find any documentation highlighting it, so I'm assuming it's a bug.
Installing
pulumi-kubernetes==4.1.0
(or any version greater than4.1.0a1691604995
) with--no-binary
with pip causesERROR: No matching distribution found for pulumi-kubernetes==4.1.0
Expected Behavior
I would expect it to install.
Steps to reproduce
pip install --no-binary :all: pulumi-kubernetes==4.1.0
Output of
pulumi about
N/A
Additional context
As far as I can tell it was broken in This PR
Using the git source as a work around by putting this in the requirements.txt:
Doesn't work because the version isn't set in the pyproject.toml
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
The text was updated successfully, but these errors were encountered: