Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent change disabled python source distribution uploads, is this intended? #2540

Closed
edude03 opened this issue Aug 23, 2023 · 4 comments
Closed
Assignees
Labels
customer/feedback Feedback from customers kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@edude03
Copy link

edude03 commented Aug 23, 2023

What happened?

Not sure if this is a bug or intended behaviour, but this used to work and doesn't anymore and I can't find any documentation highlighting it, so I'm assuming it's a bug.

Installing pulumi-kubernetes==4.1.0 (or any version greater than 4.1.0a1691604995) with --no-binary with pip causes ERROR: No matching distribution found for pulumi-kubernetes==4.1.0

Expected Behavior

I would expect it to install.

Steps to reproduce

pip install --no-binary :all: pulumi-kubernetes==4.1.0

Output of pulumi about

N/A

Additional context

As far as I can tell it was broken in This PR

Using the git source as a work around by putting this in the requirements.txt:

pulumi-kubernetes @ git+https://github.com/pulumi/pulumi-kubernetes@v4.1.0#subdirectory=sdk/python

Doesn't work because the version isn't set in the pyproject.toml

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@edude03 edude03 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Aug 23, 2023
@t0yv0
Copy link
Member

t0yv0 commented Aug 23, 2023

Hi @edude03 our intention was to transition to the wheel-based distribution. We'll look into this shortly, we were not aware of the --no-binary option or that this would be a breaking change.

CC @rquitales

@necaris
Copy link

necaris commented Aug 23, 2023

@t0yv0 I'd be curious to understand how you intend to distribute the plugin using a wheel -- from what I can see the wheel doesn't actually include the resource plugin?

@t0yv0
Copy link
Member

t0yv0 commented Aug 23, 2023

That is correct. The source distribution does not include the plugin either, but auto-installs them upon Python project installation. This redundant (optional) with Pulumi CLI auto-installing the plugins upon pulumi preview/up. The best place to discuss this is in pulumi/pulumi#13709 I think.

t0yv0 added a commit that referenced this issue Aug 23, 2023
@rquitales rquitales removed the needs-triage Needs attention from the triage team label Aug 24, 2023
@rquitales
Copy link
Contributor

Note that v4.1.1 of the Kubernetes provider was released earlier that reverted this change. Closing this issue now but feel free to reopen should more discussion need to occur.

@rquitales rquitales added the resolution/fixed This issue was fixed label Aug 24, 2023
t0yv0 added a commit that referenced this issue Sep 1, 2023
This PR introduces the following changes:

1. pyproject.toml is generated for the Python SDK, replacing setup.py
2. during build, make python_sdk now builds a source distribution and a wheel using `python -m build`
3. when publishing to PyPI, both the wheel and the source distribution are expected to be published
4. packaging is wrapped in a dedicated venv to avoid modifying the outer Python environment

Unlike the previous version that needed to be rolled back, (3) is now addressed, so #2540 does not reoccur.

---------

Co-authored-by: Levi Blackstone <levi@pulumi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer/feedback Feedback from customers kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

No branches or pull requests

4 participants