Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split nodejs provider.ts file into meaningful components #479

Closed
lblackstone opened this issue Mar 8, 2019 · 1 comment
Closed

Split nodejs provider.ts file into meaningful components #479

lblackstone opened this issue Mar 8, 2019 · 1 comment
Assignees
@lblackstone
Labels
area/sdk Related to the Kubernetes SDKs (nodejs, Python, etc.) impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features
Milestone
0.22

Comments

@lblackstone
Copy link
Member

Currently, the generated provider.ts file for the nodejs SDK is > 15000 LOC, which makes for a sluggish IDE and GitHub experience.

The generator should be updated to create multiple files that are separated by component.
@lblackstone lblackstone added impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features area/sdk Related to the Kubernetes SDKs (nodejs, Python, etc.) labels Mar 8, 2019
@lblackstone lblackstone added this to the 0.22 milestone Mar 8, 2019
@lblackstone lblackstone self-assigned this Mar 8, 2019
@hausdorff
Copy link
Contributor

We've been meaning to do this for a very long time, as it's how ~all other providers work. It will also make diffs when updating the openapi spec much cleaner. So this is not just a TS compiler usability problem.

This was referenced Mar 8, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lblackstone lblackstone

Labels
area/sdk Related to the Kubernetes SDKs (nodejs, Python, etc.) impact/usability Something that impacts users' ability to use the product easily and intuitively kind/enhancement Improvements or new features
Projects
None yet
Milestone
0.22
Development

No branches or pull requests
2 participants
@hausdorff @lblackstone