Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up nodejs SDK into multiple files #480

Merged
merged 6 commits into from
Mar 12, 2019

Conversation

lblackstone
Copy link
Member

Fixes #479

@lblackstone
Copy link
Member Author

I'm still working on fixing the exports, but the API types seem to be generating correctly at this point.

@lblackstone lblackstone force-pushed the lblackstone/split-nodejs-provider branch 2 times, most recently from fb83cff to 0249eb1 Compare March 11, 2019 22:17
@lblackstone lblackstone force-pushed the lblackstone/split-nodejs-provider branch from 0249eb1 to 83b3cf3 Compare March 11, 2019 22:25
@lblackstone lblackstone changed the title WIP: splitting up nodejs SDK into multiple files Split up nodejs SDK into multiple files Mar 11, 2019
@lblackstone lblackstone marked this pull request as ready for review March 11, 2019 22:31
Copy link
Contributor

@hausdorff hausdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see a diff of the kind generating code in provider.ts.mustache and kind.ts.mustache to make doubly sure we're ready to merge this, but other than that, I trust that our tests would fail catastrophically if we messed this up.

Copy link
Contributor

@hausdorff hausdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, why is input.ts and output.ts changing so much? Those should be diff-free right?

@lblackstone
Copy link
Member Author

Oh wait, why is input.ts and output.ts changing so much? Those should be diff-free right?

Ah, appears that the change I made in typegen.go to comment indentation inadvertently messed those up. It's not a functional change, but I'll figure out how to reverse it.

@lblackstone
Copy link
Member Author

Here's the diff:

1,5c1,7
< {{#Groups}}
< export namespace {{Group}} {
<   {{#Versions}}
<   export namespace {{Version}} {
<     {{#Kinds}}
---
> // *** WARNING: this file was generated by the Pulumi Kubernetes codegen tool. ***
> // *** Do not edit by hand unless you're certain you know what you are doing! ***
> 
> import * as pulumi from "@pulumi/pulumi";
> import * as inputApi from "../../types/input";
> import * as outputApi from "../../types/output";
> 
13d14
< 
34,39c35,40
<       * Create a {{Group}}.{{Version}}.{{Kind}} resource with the given unique name, arguments, and options.
<       *
<       * @param name The _unique_ name of the resource.
<       * @param args The arguments to use to populate this resource's properties.
<       * @param opts A bag of options that control this resource's behavior.
<       */
---
>        * Create a {{Group}}.{{Version}}.{{Kind}} resource with the given unique name, arguments, and options.
>        *
>        * @param name The _unique_ name of the resource.
>        * @param args The arguments to use to populate this resource's properties.
>        * @param opts A bag of options that control this resource's behavior.
>        */
50,56d50
<     {{/Kinds}}
<   }
< 
<   {{/Versions}}
< }
< 
< {{/Groups}}

Copy link
Contributor

@hausdorff hausdorff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright I think this makes sense, it's a little weird that the resource TS files are capitalized, but I don't see an easy way to fix that.

@lblackstone lblackstone merged commit a610ed8 into master Mar 12, 2019
@pulumi-bot pulumi-bot deleted the lblackstone/split-nodejs-provider branch March 12, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants