Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for #638 #648

Closed
hausdorff opened this issue Jul 23, 2019 · 0 comments
Closed

Add tests for #638 #648

hausdorff opened this issue Jul 23, 2019 · 0 comments
Assignees
@lblackstone
Labels
kind/engineering Work that is not visible to an external user resolution/wont-fix This issue won't be fixed

Comments

@hausdorff
Copy link
Contributor

#638 was merged prematurely, we should have tested first. Now that it's merged, though, we should follow up with the tests.
@hausdorff hausdorff self-assigned this Jul 23, 2019
@lukehoban lukehoban added this to the 0.25 milestone Jul 25, 2019
@lukehoban lukehoban modified the milestones: 0.25, 0.26 Aug 3, 2019
@ellismg ellismg modified the milestones: 0.26, 0.27 Aug 5, 2019
@lukehoban lukehoban assigned lblackstone and unassigned hausdorff Sep 18, 2019
@lblackstone lblackstone removed this from the 0.27 milestone Sep 23, 2019
@lblackstone lblackstone added kind/engineering Work that is not visible to an external user resolution/wont-fix This issue won't be fixed labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lblackstone lblackstone

Labels
kind/engineering Work that is not visible to an external user resolution/wont-fix This issue won't be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lukehoban @hausdorff @lblackstone @ellismg