Fix various usability problems in yaml.*
#638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hausdorff
force-pushed
the
hausdorff/cg-urls
branch
from
37bbedb
to
c634ada
Compare
hausdorff
changed the title
yaml.ConfigGroup to take URLs as argumentyaml.*
hausdorff
force-pushed
the
hausdorff/cg-urls
branch
3 times, most recently
from
c6d600c
to
52c1308
Compare
pgavlin
approved these changes
Jul 16, 2019
| } | ||
| } | ||
|
|
||
| /** @ignore */ function isUrl(s: string): boolean { | ||
| return s.startsWith("http://") || s.startsWith("https://") |
There was a problem hiding this comment.
Should we be instead attempt to parse a URL with https://nodejs.org/api/url.html#url_class_url and return true if parsing succeeds? This would allow us to handle file URLs, etc.
There was a problem hiding this comment.
(I do see that what you've written matches the prior behavior of ConfigFile, so no urgency here)
lblackstone
approved these changes
Jul 22, 2019
The fields of the Kubernetes core resource types are tagged with Go's `"json:"` serialization metadata. They expect things like JavaScript's `Date` to be serialized as string. Fixes #501.
lblackstone
force-pushed
the
hausdorff/cg-urls
branch
from
52c1308
to
a559e41
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #448.
Fixes #502.
Fixes #501.