Display appropriate error when pulumi plugin install fails #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #1009 This ensures we don't error but instead display an appropriate error message to ensure that Pulumi is available on the users system
lukehoban
approved these changes
Feb 28, 2020
There was a problem hiding this comment.
LGTM.
Note that this will actually also be replaced with using the unified code generator very soon - as part of #70 and pulumi/pulumi#3764 which will avoid this whole class of subtle divergences.
|
@lukehoban that is awesome to know because I spent some time trying to work out where the code was autogenerated from in this package :D |
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1009
This ensures we don't error but instead display an appropriate
error message to ensure that Pulumi is available on the users system
Proposed changes
Related issues (optional)