Sort fetched_chart_dir into alphabetical order
#1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using `fetch_opts` with the python sdk and `Fetch` with the dotnet sdk, the directory we extract the helm chart into contains 2 directories: - chart-name - chart-name-v<something>.tgz By sorting these directories into alphabetical order, we get the directory with the extracted chart in, meaning we fix the fetch opts call for both SDKs Fixes #1063
fs.readdirSync() currently will return an ordered array, but it's not expected behaviour (see nodejs/node#3232) In order to bring parity to all the SDKs, I've added an explicit sort to the returned array
jaxxstorm
force-pushed
the
jaxxstorm/helm_fetch_bugfix
branch
from
f5192c9
to
87bc3c2
Compare
lblackstone
requested changes
Apr 8, 2020
os.listdir already returns a list, so we don't need to add another one :)
lblackstone
approved these changes
Apr 8, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
fetch_optswith the python sdk, the directory we extractthe helm chart into contains 2 directories:
By sorting these directories into alphabetical order, we get the
directory with the extracted chart in, meaning we fix the fetchopts call
Proposed changes
Related issues (optional)
Fixes #1063