Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Resource for .NET SDK #1067

Merged
merged 4 commits into from
Apr 15, 2020
Merged

Conversation

mikhailshilkov
Copy link
Member

@mikhailshilkov mikhailshilkov commented Apr 14, 2020

Introduces CustomResource class for the .NET SDK.

Important design decisions:

  1. CustomResourceArgs argument type is abstract. Users are expected to derive from it and provide additional inputs for their own custom resource. See the example.
  2. apiVersion and kind must be provided as plain strings to the CustomResourceArgs constructor, although later they are assigned to corresponding input properties. That's because the type string has to be immediately resolved.

Resolves #1038

@mikhailshilkov mikhailshilkov marked this pull request as ready for review April 15, 2020 06:20
@mikhailshilkov mikhailshilkov modified the milestone: 0.34 Apr 15, 2020
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add apiextensions.CustomResource support to .NET SDK
2 participants