Switch C# codegen to schema #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
reviewed
May 19, 2020
sdk/dotnet/AdmissionRegistration/V1/Inputs/MutatingWebhookConfigurationArgs.cs
Show resolved
Hide resolved
lblackstone
approved these changes
May 19, 2020
lukehoban
approved these changes
May 28, 2020
CHANGELOG.md
Outdated
| @@ -1,5 +1,15 @@ | |||
| ## HEAD (Unreleased) | |||
|
|
|||
| ### Improvements | |||
|
|
|||
| - .NET SDK refactored to align with other .NET SDKs, e.g. ones based on Terraform. (https://github.com/pulumi/pulumi-kubernetes/pull/1132) | |||
There was a problem hiding this comment.
Suggested change
| - .NET SDK refactored to align with other .NET SDKs, e.g. ones based on Terraform. (https://github.com/pulumi/pulumi-kubernetes/pull/1132) | |
| - .NET SDK updated to align with other Pulumi .NET SDKs. (https://github.com/pulumi/pulumi-kubernetes/pull/1132) |
CHANGELOG.md
Outdated
| ### Improvements | ||
|
|
||
| - .NET SDK refactored to align with other .NET SDKs, e.g. ones based on Terraform. (https://github.com/pulumi/pulumi-kubernetes/pull/1132) | ||
| - Older resources are marked as obsolete in accordance to SDKs for other languages. |
There was a problem hiding this comment.
Suggested change
| - Older resources are marked as obsolete in accordance to SDKs for other languages. | |
| - Deprecated resources are now marked as `Obsolete`. |
CHANGELOG.md
Outdated
|
|
||
| - .NET SDK refactored to align with other .NET SDKs, e.g. ones based on Terraform. (https://github.com/pulumi/pulumi-kubernetes/pull/1132) | ||
| - Older resources are marked as obsolete in accordance to SDKs for other languages. | ||
| - Many classes are moved to new locations while preserving the namespaces and API. |
There was a problem hiding this comment.
Suggested change
| - Many classes are moved to new locations while preserving the namespaces and API. | |
| - Many classes are moved to new locations on disk while preserving the public namespaces and API. |
tests/go.mod
Outdated
| github.com/pulumi/pulumi/pkg/v2 v2.2.2-0.20200514204320-e677c7d6dca3 | ||
| github.com/pulumi/pulumi/sdk/v2 v2.2.2-0.20200514204320-e677c7d6dca3 | ||
| github.com/pulumi/pulumi/pkg/v2 v2.2.2-0.20200519094106-adfa8116fbf6 | ||
| github.com/pulumi/pulumi/sdk/v2 v2.2.2-0.20200519094106-adfa8116fbf6 |
There was a problem hiding this comment.
Minor - but can we move to a stable version of pulumi/pulumi now?
There was a problem hiding this comment.
Yes, I will rebase, depend on stable, and resolve conflicts tomorrow
mikhailshilkov
force-pushed
the
mikhailshilkov/schema-dotnet-gen
branch
from
1bf9a72
to
5ed063a
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Switch the generation of the .NET SDK to schema-based one (except for the YAML overlay)
Related issues (optional)
Fixes #1084