Update resource deprecation/removal warnings #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
force-pushed
the
lblackstone/update-removal
branch
from
1cca3dd
to
42bf71b
Compare
metral
reviewed
Jun 12, 2020
| @@ -196,3 +202,15 @@ const ( | |||
| StorageV1A1 groupVersion = "storage.k8s.io/v1alpha1" | |||
| StorageV1B1 groupVersion = "storage.k8s.io/v1beta1" | |||
| ) | |||
|
|
|||
| // toGVK is a helper function that converts the internal groupVersion and Kind types to a schema.GroupVersionKind | |||
| func toGVK(gv groupVersion, kind Kind) schema.GroupVersionKind { | |||
There was a problem hiding this comment.
I could be mistaken, but doesn't a similar helper function exist somewhere?
There was a problem hiding this comment.
There are similar methods that take string inputs, but not these internal types.
metral
approved these changes
Jun 12, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Updated the warnings based on the most recent upstream changelogs
Related issues (optional)
Fix #1161