Add support for kustomize #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new kustomize.Directory class to each SDK that allows Pulumi to directly manage kustomizations.
metral
suggested changes
Jun 29, 2020
There was a problem hiding this comment.
Overall LGTM -- it's great to see the relatively quick turn around on this given the investment in autogeneration 🎉
Added a couple of comments, and generally was curious if we could consolidate the kustomization helloworld example being tested in the 4 languages. Specifically, we repeat kustomization.yaml, deployment.yaml, service.yaml, configmap.yaml etc. across all tests that does not appear to change from language to language.
| } | ||
| defer os.RemoveAll(temp) | ||
|
|
||
| path, err = workspace.RetrieveGitFolder(directory, temp) |
There was a problem hiding this comment.
How do we plan on handling auth for private git repos?
There was a problem hiding this comment.
The package I'm using for git support doesn't expose auth options. I'm inclined to leave it as is for now and add support later if it's needed.
# Conflicts: # CHANGELOG.md
metral
approved these changes
Jul 1, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add a new kustomize.Directory class to each SDK that allows
Pulumi to directly manage kustomizations.
TODO:
Related issues (optional)
Fix #370